Commit f3bfa932 authored by Gianluca Marotta's avatar Gianluca Marotta
Browse files

Merge branch 'open-issues' into 'master'

FIx bug on Off command

See merge request ska-telescope/csp-lmc!20
parents dd859560 cea100c8
Loading
Loading
Loading
Loading
Loading
+4 −2
Original line number Diff line number Diff line
@@ -597,14 +597,16 @@ class CspSubarray(SKASubarray):
            for fqdn in subelement_thr.keys():
                subelement_thr[fqdn].join()

            if all(self.empty_succeeded[fqdn] for fqdn in device_to_turn_off):
            if all(self.empty_succeeded[fqdn] for fqdn in device_to_turn_off) and device_to_turn_off:
                
                result_code = ResultCode.FAILED

                for fqdn in device_to_turn_off:
                    try:
                        self.logger.info('Sending Off Command...')
                        (result_code, message) = device._sc_subarray_proxies[fqdn].Off()
                    except tango.DevFailed as tango_err:
                        message = str(tango_err.args[0].desc)
                        result_code = ResultCode.FAILED

                if result_code == ResultCode.FAILED:
                    self.logger.error("Off command failed on device {}".format(fqdn))