Unverified Commit c5bf71ee authored by Kelvin Rodriguez's avatar Kelvin Rodriguez Committed by GitHub
Browse files

5.0.1 version tick and bug fixes (#4524) 



* Change measure log name to be case-insensitive (#4441)

* Lrowac2pds App and Test Conversion (#4429)

* lrowac2pds app conversion

* Lrowac2pds App and Test Conversion

* Set global variables to static to prevent test failures

* Gui Parameters now right aligned (#4507)

* Findgaps gtests (#4422)

* first few test cases, needs work

* two working tests

* add test for correlation tolerance

* improve test data creation code

* updated mapcam makefile (#4498)

* merge conflict with 561e21e9 in changelog

* improve grid extend test case (#4506)

* fix sample_bits pvl output (#4500)

* map2map conversion (#4435)

* added code for two tests

* test modifications

* changed crop input and ouput function

* fixed last two tests

* added more tests

* converted map2map

* added conversion code for map2map

* bring crop tests up to date with dev

* added modifications to map2map and tests

* final changes for map2map tests

* Converted app and default test

* Converted tests

* Added histograms to tests.

* Rename FunctionalTestsMap2Map.cpp to FunctionalTestsMap2map.cpp

Co-authored-by: default avatarAmy Stamile <astamile@contractor.usgs.gov>
Co-authored-by: default avatarAmy Stamile <74275278+amystamile-usgs@users.noreply.github.com>

* thm2isis now uses out attrs and converted to func (#4504)

* thm2isis now uses out attrs and converted to func

* removed commented code that manually set pixel type

* added gtests

* better params

* IR test added

* reordered things

* cropped images

* cropped image for outattr tests too

* added missing changelog lines

* Fix caminfo uselabel SegFault (#4402)

* conditionally reopen cube to prevent segfault

* relocate cube close

* version ticks

* change log merge conflict

* added 5.0.1 bugfixes under a 5.0.1 header in CHANGELOG

* removed unreleased portion of the changelog

Co-authored-by: default avatarJesse Mapel <jmapel@usgs.gov>
Co-authored-by: default avatarAmy Stamile <74275278+amystamile-usgs@users.noreply.github.com>
Co-authored-by: default avatarTim Giroux <62255438+tgiroux@users.noreply.github.com>
Co-authored-by: default avatarrobotprogrammer22 <46390033+robotprogrammer22@users.noreply.github.com>
Co-authored-by: default avatarAmy Stamile <astamile@contractor.usgs.gov>
parent adf52de0

CHANGELOG.md

+12 −1
Original line number Diff line number Diff line
@@ -33,7 +33,18 @@ heading to indicate that only the bug fixes and security fixes are in the bug fi 
release.

-->



## [Unreleased]

## [5.0.1] - 2021-06-10



### Fixed

- Fixed logging in FindFeatures where we were trying to get a non-existent Pvl group from the Pvl log. [#4375](https://github.com/USGS-Astrogeology/ISIS3/issues/4375)

- Fixed an arccos evaluating a double close to either 1, -1 when calculating the ground azimuth in camera.cpp. [#4393](https://github.com/USGS-Astrogeology/ISIS3/issues/4393)

- Fixed hist outputs to N/A when all DNs are special pixels. [#3709](https://github.com/USGS-Astrogeology/ISIS3/issues/3709)

- Fixed an Minimum|Maximum calculation error when comparing all equal data in the qview statstics tool. [#4433](https://github.com/USGS-Astrogeology/ISIS3/issues/4414)

- Fixed SolarLon to compute from Table if cube is spiceinited. [#3703](https://github.com/USGS-Astrogeology/ISIS3/issues/3703)

- Fixed GUI alignment to be top aligned rather than centered to make parameters less ambiguous. [#3710](https://github.com/USGS-Astrogeology/ISIS3/issues/3710)

- Fixed hideal2pds bug where parameterizing for 8-bit output create 18-bit output. [#4006](https://github.com/USGS-Astrogeology/ISIS3/issues/4006)

- Fixed Thm2isis to properly use output attributes [#4213](https://github.com/USGS-Astrogeology/ISIS3/issues/4213)

- Fixed caminfo uselabel SegFault. [#4401](https://github.com/USGS-Astrogeology/ISIS3/issues/4401)



## [5.0.0] - 2021-04-01

isis/CMakeLists.txt

+1 −1
Original line number Diff line number Diff line
@@ -33,7 +33,7 @@ set(PACKAGE "ISIS") 
set(PACKAGE_NAME       "USGS ISIS")



# Version number

set(VERSION            "5.0.0")

set(VERSION            "5.0.1")

string(REPLACE "." ";" VERSION_LIST ${VERSION})

list(GET VERSION_LIST 0 VERSION_MAJOR)

list(GET VERSION_LIST 1 VERSION_MINOR)

isis/src/base/apps/caminfo/CamTools.cpp

+0 −1
Original line number Diff line number Diff line
@@ -335,7 +335,6 @@ namespace Isis { 
      if (getFootBlob && band == 0) {

        // Read the footprint from the image labels

        ImagePolygon poly = cube.readFootprint();

        cube.close();

        geos::geom::MultiPolygon *multiP = poly.Polys();

        _polys.push_back(multiP->clone());

        _combined = multiP->clone();

isis/src/base/apps/caminfo/caminfo.cpp

+3 −1
Original line number Diff line number Diff line
@@ -434,6 +434,8 @@ namespace Isis{ 
        else

          GenerateCSVOutput(incube, general, camstats, statistics, bandGeom, ui);



        incube->close();



        // Clean the data

        delete general;

        general = NULL;

isis/src/base/apps/findgaps/findgaps.cpp

0 → 100644
+77 −0
Original line number Diff line number Diff line 
/**

 * @file

 * $Revision: 1.19 $

 * $Date: 2010/03/22 19:44:53 $

 *

 *   Unless noted otherwise, the portions of Isis written by the USGS are

 *   public domain. See individual third-party library and package descriptions

 *   for intellectual property information, user agreements, and related

 *   information.

 *

 *   Although Isis has been used by the USGS, no warranty, expressed or

 *   implied, is made by the USGS as to the accuracy and functioning of such

 *   software and related material nor shall the fact of distribution

 *   constitute any such warranty, and no responsibility is assumed by the

 *   USGS in connection therewith.

 *

 *   For additional information, launch

 *   $ISISROOT/doc//documents/Disclaimers/Disclaimers.html

 *   in a browser or see the Privacy &amp; Disclaimers page on the Isis website,

 *   http://isis.astrogeology.usgs.gov, and the USGS privacy and disclaimers on

 *   http://www.usgs.gov/privacy.html.

 */

#include <QMessageBox>



#include "FindGapsFunctor.h"

#include "IException.h"

#include "IString.h"

#include "MultivariateStatistics.h"

#include "ProcessByLine.h"

#include "ProcessBySample.h"

#include "SpecialPixel.h"

#include "Statistics.h"

#include "findgaps.h"



using namespace std;



namespace Isis {



  void findgaps(UserInterface &ui) {

    double corTol = ui.GetDouble("CORTOL"); // The correlation tolerance

    int bufferSizeBeforeGap = ui.GetInteger("ABOVE");

    int bufferSizeAfterGap = ui.GetInteger("BELOW");

    bool outputCubeSpecified = (ui.GetAsString("TO") != "none");

    bool logFileSpecified = (ui.GetAsString("LOG") != "none");



    CubeAttributeOutput &att = ui.GetOutputAttribute("TO");



    Cube *iCube = new Cube();

    iCube->open(ui.GetFileName("FROM"), "r");



    if (outputCubeSpecified || logFileSpecified) {

      ProcessByLine p;

      p.SetInputCube(iCube);



      FindGapsFunctor gapsFunctor(iCube->lineCount(), corTol, bufferSizeBeforeGap,

                                  bufferSizeAfterGap);

      p.ProcessCubeInPlace(gapsFunctor, false);



      if (outputCubeSpecified) {

        gapsFunctor.setModification("NULL buffers added to output cube");

        

        p.SetOutputCube(ui.GetFileName("TO"), att);



        p.ProcessCube(gapsFunctor, false);

      }



      if (logFileSpecified) {

        gapsFunctor.gaps().write(ui.GetFileName("LOG"));

      }

    }

    else {

      throw IException(IException::User,

                      "At least one form of output (a log file or cube) needs to be entered.",

                      _FILEINFO_);

    }

  }

}
 
 No newline at end of file