Unverified Commit 561e21e9 authored Jun 02, 2021 by Amy Stamile Committed by GitHub Jun 02, 2021

Fixed SolarLon to compute from Table if cube is spiceinited (#4418)

* Updated solarLon to used table when spiceinited

* Updated truth data for CameraPointInfo

* Updated changelog

* Updated camdev test outputs

parent c978036e

CHANGELOG.md

+1 −0

Original line number	Diff line number	Diff line
		@@ -43,6 +43,7 @@ release.
		- Fixed an arccos evaluating a double close to either 1, -1 when calculating the ground azimuth in camera.cpp. [#4393](https://github.com/USGS-Astrogeology/ISIS3/issues/4393)
		- Fixed hist outputs to N/A when all DNs are special pixels. [#3709](https://github.com/USGS-Astrogeology/ISIS3/issues/3709)
		- Fixed an Minimum\|Maximum calculation error when comparing all equal data in the qview statstics tool. [#4433](https://github.com/USGS-Astrogeology/ISIS3/issues/4414)
		- Fixed SolarLon to compute from Table if cube is spiceinited. [#3703](https://github.com/USGS-Astrogeology/ISIS3/issues/3703)

		## [5.0.0] - 2021-04-01

isis/src/base/objs/CameraPointInfo/CameraPointInfo.truth

+2 −2

Original line number	Diff line number	Diff line
		@@ -51,7 +51,7 @@ Group = GroundPoint
		EphemerisTime = -182103311.79772 <seconds>
		UTC = 1994-03-25T19:43:48.0166464
		LocalSolarTime = 12.59760019772 <hour>
		SolarLongitude = 129.01790468942 <DEGREE>
		SolarLongitude = 129.01116499267 <DEGREE>

		# Look Direction Unit Vectors in Body Fixed, J2000, and Camera Coordinate Systems.
		LookDirectionBodyFixed = (-0.13147866432244, 0.010191826600814,
		@@ -114,7 +114,7 @@ Group = GroundPoint
		EphemerisTime = -182103311.79772 <seconds>
		UTC = 1994-03-25T19:43:48.0166464
		LocalSolarTime = 11.791629846611 <hour>
		SolarLongitude = 129.01790468942 <DEGREE>
		SolarLongitude = 129.01116499267 <DEGREE>

		# Look Direction Unit Vectors in Body Fixed, J2000, and Camera Coordinate Systems.
		LookDirectionBodyFixed = (-0.076075624316564, -0.015172515119546,

isis/src/base/objs/Spice/Spice.cpp

+1 −1

Original line number	Diff line number	Diff line
		@@ -1405,7 +1405,7 @@ namespace Isis {
		return;
		}

		if (m_usingAle) {
		if (m_usingAle \|\| !m_usingNaif) {
		double og_time = m_bodyRotation->EphemerisTime();
		m_bodyRotation->SetEphemerisTime(et.Et());
		m_sunPosition->SetEphemerisTime(et.Et());

isis/tests/FunctionalTestsCamdev.cpp

+4 −4

Original line number	Diff line number	Diff line
		@@ -96,8 +96,8 @@ TEST_F(LineScannerCube, FunctionalTestCamdevDefault) {
		stddev += oCubeStats->StandardDeviation();
		}

		EXPECT_NEAR(average/oCube.bandCount(), -3.3918738393628582e+306, 0.0000001);
		EXPECT_NEAR(sum/oCube.bandCount(), 112847425994.19986, 0.0000001);
		EXPECT_NEAR(stddev/oCube.bandCount(),-3.3918738393628582e+306, 0.0000001);
		EXPECT_NEAR(validPixels/oCube.bandCount(), 11832.33962264151, 0.0000001);
		EXPECT_NEAR(average/oCube.bandCount(), 9183553.1942929607, 0.0000001);
		EXPECT_NEAR(sum/oCube.bandCount(), 112847454091.56306, 0.0000001);
		EXPECT_NEAR(stddev/oCube.bandCount(), 11.299672545293422, 0.0000001);
		EXPECT_NEAR(validPixels/oCube.bandCount(), 12064.188679245282, 0.0000001);
		}

isis/tests/FunctionalTestsCaminfo.cpp

+1 −1

Original line number	Diff line number	Diff line
		@@ -206,7 +206,7 @@ TEST_F(DefaultCube, FunctionalTestCaminfoDefault) {
		EXPECT_NEAR(geometry.findKeyword("IncidenceAngle"), 70.127983086993, 0.0001);
		EXPECT_NEAR(geometry.findKeyword("NorthAzimuth"), 332.65918485196, 0.0001);
		EXPECT_NEAR(geometry.findKeyword("OffNadir"), 9.9273765164008, 0.0001);
		EXPECT_NEAR(geometry.findKeyword("SolarLongitude"), -1.7976931348623099e+308, 0.0001);
		EXPECT_NEAR(geometry.findKeyword("SolarLongitude"), 294.73518830594998, 0.0001);
		EXPECT_NEAR(geometry.findKeyword("LocalTime"), 7.7862975334032, 0.0001);
		EXPECT_NEAR(geometry.findKeyword("TargetCenterDistance"), 4160.7294345949, 0.0001);
		EXPECT_NEAR(geometry.findKeyword("SlantDistance"), 762.37204489156, 0.0001);