Unverified Commit 5caf0bde authored by Amy Stamile's avatar Amy Stamile Committed by GitHub
Browse files

Fixes Maptrim failure when mode=both (#4682) 

* Fixes issues with updating Mapping in Crop app when PositiveWest.

* Fixed copy/paste error.

* Changelog

* Reverted planetographic changes.

* Fixed subarea unit test failures.
parent 2c40e08c

CHANGELOG.md

+1 −0
Original line number Diff line number Diff line
@@ -53,6 +53,7 @@ Keywords when running CAMSTATS. [#3605](https://github.com/USGS-Astrogeology/IS 
- Deprecated edrget as discussed in [#3313](https://github.com/USGS-Astrogeology/ISIS3/issues/3313).



### Fixed

- Fixed Maptrim failures when mode=both for PositiveWest longitude direction. [#4646](https://github.com/USGS-Astrogeology/ISIS3/issues/4646)

- Fixed the Vesta target name not being translated properly in dawnfc2isis. [#4638](https://github.com/USGS-Astrogeology/ISIS3/issues/4638)

- Fixed a bug where the measure residuals reported in the bundleout.txt file were incorrect. [#4655](https://github.com/USGS-Astrogeology/ISIS3/issues/4655)

isis/src/base/objs/SubArea/SubArea.cpp

+10 −6
Original line number Diff line number Diff line
@@ -191,9 +191,11 @@ namespace Isis { 
              }

            }

            else {

              minlon = proj->ToPositiveWest(proj->UniversalLongitude(), 360);

              if (proj->Has180Domain()) {

                minlon = proj->To180Domain(proj->ToPositiveWest(proj->UniversalLongitude(), 360));

              if (proj->Has360Domain()) {

                minlon = proj->ToPositiveWest(proj->Longitude(), 360);

              }

              else {

                minlon = proj->ToPositiveWest(proj->Longitude(), 180);

              }

            }

            proj->SetWorld(p_es+.5, p_el+.5);
@@ -209,9 +211,11 @@ namespace Isis { 
                }

              }

              else {

                maxlon = proj->ToPositiveWest(proj->UniversalLongitude(), 360);

                if (proj->Has180Domain()) {

                  maxlon = proj->To180Domain(proj->ToPositiveWest(proj->UniversalLongitude(), 360));

                if (proj->Has360Domain()) {

                  maxlon = proj->ToPositiveWest(proj->Longitude(), 360);

                }

                else {

                  maxlon = proj->ToPositiveWest(proj->Longitude(), 180);

                }

              }

              mapgroup.addKeyword(PvlKeyword("MinimumLatitude",toString(minlat)),Pvl::Replace);