Newer
Older
Alinga Yeung
committed
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
/*
************************************************************************
******************* CANADIAN ASTRONOMY DATA CENTRE *******************
************** CENTRE CANADIEN DE DONNÉES ASTRONOMIQUES **************
*
* (c) 2015. (c) 2015.
* Government of Canada Gouvernement du Canada
* National Research Council Conseil national de recherches
* Ottawa, Canada, K1A 0R6 Ottawa, Canada, K1A 0R6
* All rights reserved Tous droits réservés
*
* NRC disclaims any warranties, Le CNRC dénie toute garantie
* expressed, implied, or énoncée, implicite ou légale,
* statutory, of any kind with de quelque nature que ce
* respect to the software, soit, concernant le logiciel,
* including without limitation y compris sans restriction
* any warranty of merchantability toute garantie de valeur
* or fitness for a particular marchande ou de pertinence
* purpose. NRC shall not be pour un usage particulier.
* liable in any event for any Le CNRC ne pourra en aucun cas
* damages, whether direct or être tenu responsable de tout
* indirect, special or general, dommage, direct ou indirect,
* consequential or incidental, particulier ou général,
* arising from the use of the accessoire ou fortuit, résultant
* software. Neither the name de l'utilisation du logiciel. Ni
* of the National Research le nom du Conseil National de
* Council of Canada nor the Recherches du Canada ni les noms
* names of its contributors may de ses participants ne peuvent
* be used to endorse or promote être utilisés pour approuver ou
* products derived from this promouvoir les produits dérivés
* software without specific prior de ce logiciel sans autorisation
* written permission. préalable et particulière
* par écrit.
*
* This file is part of the Ce fichier fait partie du projet
* OpenCADC project. OpenCADC.
*
* OpenCADC is free software: OpenCADC est un logiciel libre ;
* you can redistribute it and/or vous pouvez le redistribuer ou le
* modify it under the terms of modifier suivant les termes de
* the GNU Affero General Public la “GNU Affero General Public
* License as published by the License” telle que publiée
* Free Software Foundation, par la Free Software Foundation
* either version 3 of the : soit la version 3 de cette
* License, or (at your option) licence, soit (à votre gré)
* any later version. toute version ultérieure.
*
* OpenCADC is distributed in the OpenCADC est distribué
* hope that it will be useful, dans l’espoir qu’il vous
* but WITHOUT ANY WARRANTY; sera utile, mais SANS AUCUNE
* without even the implied GARANTIE : sans même la garantie
* warranty of MERCHANTABILITY implicite de COMMERCIALISABILITÉ
* or FITNESS FOR A PARTICULAR ni d’ADÉQUATION À UN OBJECTIF
* PURPOSE. See the GNU Affero PARTICULIER. Consultez la Licence
* General Public License for Générale Publique GNU Affero
* more details. pour plus de détails.
*
* You should have received Vous devriez avoir reçu une
* a copy of the GNU Affero copie de la Licence Générale
* General Public License along Publique GNU Affero avec
* with OpenCADC. If not, see OpenCADC ; si ce n’est
* <http://www.gnu.org/licenses/>. pas le cas, consultez :
* <http://www.gnu.org/licenses/>.
*
*
************************************************************************
*/
package ca.nrc.cadc.ac.server.web;
import static org.easymock.EasyMock.createMock;
import static org.easymock.EasyMock.expect;
import static org.easymock.EasyMock.expectLastCall;
import static org.easymock.EasyMock.replay;
import static org.easymock.EasyMock.verify;
Alinga Yeung
committed
import java.security.PrivilegedExceptionAction;
Alinga Yeung
committed
import javax.security.auth.Subject;
import javax.servlet.ServletConfig;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.log4j.Level;
import org.junit.AfterClass;
import org.junit.BeforeClass;
import org.junit.Test;
Alinga Yeung
committed
import ca.nrc.cadc.ac.server.UserPersistence;
import ca.nrc.cadc.auth.HttpPrincipal;
import ca.nrc.cadc.util.Log4jInit;
import ca.nrc.cadc.util.PropertiesReader;
import ca.nrc.cadc.util.StringUtil;
Alinga Yeung
committed
public class ModifyPasswordServletTest
{
public ModifyPasswordServletTest()
{
Log4jInit.setLevel("ca.nrc.cadc.ac", Level.INFO);
}
@BeforeClass
public static void setUpClass()
{
System.setProperty(PropertiesReader.class.getName() + ".dir", "src/test/resources");
}
@AfterClass
public static void teardownClass()
{
System.clearProperty(PropertiesReader.class.getName() + ".dir");
}
public void testSubjectAndPasswords(final Subject subject, final String oldPassword,
final String newPassword, int responseStatus) throws Exception
Alinga Yeung
committed
{
@SuppressWarnings("serial")
final ModifyPasswordServlet testSubject = new ModifyPasswordServlet()
{
@Override
Subject getSubject(final HttpServletRequest request)
{
return subject;
}
};
Alinga Yeung
committed
final HttpServletRequest mockRequest =
createMock(HttpServletRequest.class);
final HttpServletResponse mockResponse =
createMock(HttpServletResponse.class);
Alinga Yeung
committed
expect(mockRequest.getPathInfo()).andReturn("users/CADCtest").once();
expect(mockRequest.getMethod()).andReturn("POST").once();
expect(mockRequest.getRemoteAddr()).andReturn("mysite.com").once();
if (!StringUtil.hasText(oldPassword) || !StringUtil.hasText(newPassword))
{
expect(mockRequest.getParameter("old_password")).andReturn(oldPassword).once();
expect(mockRequest.getParameter("new_password")).andReturn(newPassword).once();
}
if (responseStatus != 200)
{
mockResponse.setContentType("text/plain");
expectLastCall().once();
}
mockResponse.setStatus(responseStatus);
Alinga Yeung
committed
expectLastCall().once();
Alinga Yeung
committed
replay(mockRequest, mockResponse);
Alinga Yeung
committed
Subject.doAs(subject, new PrivilegedExceptionAction<Void>()
{
@Override
public Void run() throws Exception
{
testSubject.doPost(mockRequest, mockResponse);
return null;
}
});
Alinga Yeung
committed
verify(mockRequest, mockResponse);
}
Alinga Yeung
committed
@Test
public void testModifyPasswordWithNullSubject() throws Exception
{
final Subject subject = null;
testSubjectAndPasswords(subject, "oldPass", "newPass", HttpServletResponse.SC_UNAUTHORIZED);
Alinga Yeung
committed
}
Alinga Yeung
committed
@Test
public void testModifyPasswordWithEmptySubject() throws Exception
{
final Subject subject = new Subject();;
testSubjectAndPasswords(subject, "oldPass", "newPass", HttpServletResponse.SC_UNAUTHORIZED);
Alinga Yeung
committed
}
Alinga Yeung
committed
@Test
public void testModifyPasswordWithMissingOldPassword() throws Exception
{
final Subject subject = new Subject();;
subject.getPrincipals().add(new HttpPrincipal("CADCtest"));
testSubjectAndPasswords(subject, "", "newPass", HttpServletResponse.SC_BAD_REQUEST);
Alinga Yeung
committed
}
Alinga Yeung
committed
@Test
public void testModifyPasswordWithMissingNewPassword() throws Exception
{
final Subject subject = new Subject();;
subject.getPrincipals().add(new HttpPrincipal("CADCtest"));
testSubjectAndPasswords(subject, "oldPass", "", HttpServletResponse.SC_BAD_REQUEST);
Alinga Yeung
committed
}
public void testModifyPassword(final boolean hasInternalServerError) throws Exception
Alinga Yeung
committed
{
final String oldPassword = "oldPass";
final String newPassword = "newPass";
HttpPrincipal userID = new HttpPrincipal("CADCtest");
Brian Major
committed
final UserPersistence mockUserPersistence =
Alinga Yeung
committed
createMock(UserPersistence.class);
mockUserPersistence.setPassword(userID, oldPassword, newPassword);
if (hasInternalServerError)
{
expectLastCall().andThrow(new RuntimeException());
}
Alinga Yeung
committed
final Subject subject = new Subject();
subject.getPrincipals().add(userID);
Alinga Yeung
committed
@SuppressWarnings("serial")
final ModifyPasswordServlet testSubject = new ModifyPasswordServlet()
{
@Override
public void init(final ServletConfig config) throws ServletException
{
super.init();
userPersistence = mockUserPersistence;
}
Alinga Yeung
committed
@Override
Subject getSubject(final HttpServletRequest request)
{
return subject;
}
};
Alinga Yeung
committed
final HttpServletRequest mockRequest =
createMock(HttpServletRequest.class);
final HttpServletResponse mockResponse =
createMock(HttpServletResponse.class);
Alinga Yeung
committed
expect(mockRequest.getPathInfo()).andReturn("users/CADCtest").once();
expect(mockRequest.getMethod()).andReturn("POST").once();
expect(mockRequest.getRemoteAddr()).andReturn("mysite.com").once();
expect(mockRequest.getParameter("old_password")).andReturn(oldPassword).once();
expect(mockRequest.getParameter("new_password")).andReturn(newPassword).once();
if (hasInternalServerError)
{
mockResponse.setContentType("text/plain");
expectLastCall().once();
mockResponse.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
expectLastCall().once();
}
Alinga Yeung
committed
replay(mockRequest, mockResponse, mockUserPersistence);
Alinga Yeung
committed
Subject.doAs(subject, new PrivilegedExceptionAction<Void>()
{
@Override
public Void run() throws Exception
{
testSubject.init(null);
testSubject.doPost(mockRequest, mockResponse);
return null;
}
});
Alinga Yeung
committed
verify(mockRequest, mockResponse, mockUserPersistence);
}
Alinga Yeung
committed
@Test
public void testModifyPasswordWithInternalServerError() throws Exception
Alinga Yeung
committed
{
boolean hasInternalServerError = true;
testModifyPassword(hasInternalServerError);
}
@Test
public void testModifyPasswordHappyPath() throws Exception
{
boolean hasInternalServerError = false;
testModifyPassword(hasInternalServerError);