-
Function `stop` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
def stop(self, sagCallback): """ [Async] Tell the reco process to stop the analysis. The callback status is set to DONE when all the data receveid until the stop() call is processed. """ self._logger.logInfo("[SAGRecoImpl - stop]") data = {} sagCallback.working(json.dumps(data)) if self.status == STATUS.NOT_STARTED: self._logger.logInfo("[SAGRecoImpl - stop] Status was 'NOT_STARTED' no process to be killed") sagCallback.done(json.dumps({}))Details
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Found in sag_supervisor/src/SAG_IMPL_MODULE/SAGRecoImpl.py by structure -
Function `stopAndDeactivatePipelines` has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
[Async] Stop the reco,data quality and sci processes. Deactivate the SAGReco, SAGSci and SAGDataQuality components asynchronously. """ def stopAndDeactivatePipelines(self, sagCallback): sagCallback.working(json.dumps({})) recoComponentName = self.recoComponentBaseName + str(self.subArrayID) dqComponentName = self.dqComponentBaseName + str(self.subArrayID) sciComponentName = self.sciComponentBaseName + str(self.subArrayID) recoStatus = self.containerUtility.checkIfActive(recoComponentName) self._logger.logInfo(f"[SAGSubArrayManagerImpl {self.subArrayID}] ====> reco STATUS = "+str(recoStatus)) if recoStatus == 0 or recoStatus == 1: sagCallback.err(json.dumps({"exception":"SAGRecoAlreadyDeactivatedExImpl"}))Details
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Found in sag_supervisor/src/SAG_IMPL_MODULE/SAGSubArrayManagerImpl.py by structure -
Function `stopAndDeactivatePipelines` has 28 lines of code (exceeds 25 allowed). Consider refactoring.
[Async] Stop the reco,data quality and sci processes. Deactivate the SAGReco, SAGSci and SAGDataQuality components asynchronously. """ def stopAndDeactivatePipelines(self, sagCallback): sagCallback.working(json.dumps({})) recoComponentName = self.recoComponentBaseName + str(self.subArrayID) dqComponentName = self.dqComponentBaseName + str(self.subArrayID) sciComponentName = self.sciComponentBaseName + str(self.subArrayID) recoStatus = self.containerUtility.checkIfActive(recoComponentName) self._logger.logInfo(f"[SAGSubArrayManagerImpl {self.subArrayID}] ====> reco STATUS = "+str(recoStatus)) if recoStatus == 0 or recoStatus == 1: sagCallback.err(json.dumps({"exception":"SAGRecoAlreadyDeactivatedExImpl"}))Found in sag_supervisor/src/SAG_IMPL_MODULE/SAGSubArrayManagerImpl.py by structure -
Function `startMonitoring` has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
return [comp for comp in components if "MANAGERID_"+subarrayID in comp.name] def startMonitoring(self): """ [Async] Start the monitoring of the SAGReco, SAGDataQuality and SAGSci components for each scheduling block. The monitoring data is sent to external subsystems. """ self._logger.logInfo("[SAGSubArrayMonitorImpl - startMonitoring] Start monitoring") self.monitor = True while self.monitor: self._logger.logInfo("[SAGSubArrayMonitorImpl - startMonitoring] monitoring..")Details
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Found in sag_supervisor/src/SAG_IMPL_MODULE/SAGSubArrayMonitorImpl.py by structure -
Function `checkIfActive` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
self.acsPySimpleClient = PySimpleClient() def checkIfActive(self, componentName): """ TODO L'uso di PySimpleClient() è superfluo, il metodo availableComponents() è già parte di questa classe perchè viene eridatato da ContainerServices. La chiamata a quel metodo però da errore... """ # ATTENZIONE: si potrebbe usare la getInstance() MA, chiamata a getInstance() + chiamata a disconnect() + chiamata a getInstance() + chiamata a availableComponents() => ACS ERROR!! availableComponents = self.acsPySimpleClient.availableComponents() #availableComponents = self.availableComponents() found = FalseDetails
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Found in sag_supervisor/src/UTILITY_IMPL_MODULE/ContainerUtilityImpl.py by structure -
Identical blocks of code found in 2 locations. Consider refactoring.
""" def __init__(self): ACSComponent.__init__(self) ContainerServices.__init__(self) self._logger = self.getLogger() self.sbID = None self.status = 0 ## Lifecycle ##Other instances
sag_supervisor/src/SAG_IMPL_MODULE/SAGSciImpl.py
""" def __init__(self): ACSComponent.__init__(self) ContainerServices.__init__(self) self._logger = self.getLogger() self.sbID = None self.status = 0 ## Lifecycle ##Details
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 49.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See
codeclimate-duplication's documentation for more information about tuning the mass threshold in your.codeclimate.yml.Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Found in sag_supervisor/src/SAG_IMPL_MODULE/SAGDataQualityImpl.py by duplication -
Identical blocks of code found in 2 locations. Consider refactoring.
""" def __init__(self): ACSComponent.__init__(self) ContainerServices.__init__(self) self._logger = self.getLogger() self.sbID = None self.status = 0 ## Lifecycle ##Other instances
sag_supervisor/src/SAG_IMPL_MODULE/SAGDataQualityImpl.py
""" def __init__(self): ACSComponent.__init__(self) ContainerServices.__init__(self) self._logger = self.getLogger() self.sbID = None self.status = 0 ## Lifecycle ##Details
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 49.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See
codeclimate-duplication's documentation for more information about tuning the mass threshold in your.codeclimate.yml.Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Found in sag_supervisor/src/SAG_IMPL_MODULE/SAGSciImpl.py by duplication -
TODO found
def checkIfActive(self, componentName): """ TODO L'uso di PySimpleClient() è superfluo, il metodo availableComponents() è già parte di questa classe perchè viene eridatato da ContainerServices. La chiamata a quel metodo però da errore...Found in sag_supervisor/src/UTILITY_IMPL_MODULE/ContainerUtilityImpl.py by fixme