Commit 49011e4f authored by Andrea Bignamini's avatar Andrea Bignamini
Browse files

Remove check on remote columns 

The check on same number of columns has been removed.
The check on not found column has been removed.
In this way the remote table can possibly have columns
not mapped by Nadir.
parent aad03198

src/ProtocolManager.cpp

+15 −13
Original line number Diff line number Diff line
@@ -178,13 +178,14 @@ ResponseSP ProtocolManager::prepareValidation(RequestSP request_sp) 
                        throw std::runtime_error(errorStream.str());

                    }



                    if(validationReq.columns_size() != (int)informationList.size())

                    {

                        std::stringstream errorStream;

                        errorStream << "Table " << m_validatedSchema << "."

                            << m_validatedTable << " has different columns size";

                        throw std::runtime_error(errorStream.str());

                    }

		    // Same number of columns check removed

                    // if(validationReq.columns_size() != (int)informationList.size())

                    // {

                    //     std::stringstream errorStream;

                    //     errorStream << "Table " << m_validatedSchema << "."

                    //         << m_validatedTable << " has different columns size";

                    //     throw std::runtime_error(errorStream.str());

                    // }



                    for(int i=0; i<validationReq.columns_size(); ++i)

                        validateColumn(validationReq.columns(i), informationList);
@@ -378,12 +379,13 @@ void ProtocolManager::validateColumn(const Request::Validation::Column& column, 
        }

    }



    if(!found)

    {

        std::stringstream errorStream;

        errorStream << "Column " << column.name() << " not found";

        throw std::runtime_error(errorStream.str());

    }

    // Column not found check removed

    // if(!found)

    // {

    //     std::stringstream errorStream;

    //     errorStream << "Column " << column.name() << " not found";

    //     throw std::runtime_error(errorStream.str());

    // }

}



//==============================================================================