Commit d521b9f2 authored by Elisabetta Giani's avatar Elisabetta Giani
Browse files

AT5-262: implementing code review advices.

parent 709068de

csp-lmc-common/csp_lmc_common/CspMaster.py

+4 −1
Original line number Diff line number Diff line
@@ -195,7 +195,7 @@ class CspMaster(with_metaclass(DeviceMeta, SKAMaster)): 
        dev_name = evt.device.dev_name()

        if not evt.err:

            try:

                if evt.attr_value.name.lower().find("commandprogress") > -1:

                if "commandprogress" == evt.attr_value.name.lower()[-15:]:

                    if dev_name in self._se_fqdn:

                        # get the command name (on/off/standby) from the attribute name 

                        # (onCommandProgress/offCommandProgress/standbyCommandProgress))
@@ -1188,6 +1188,9 @@ class CspMaster(with_metaclass(DeviceMeta, SKAMaster)): 
                                                         if key == '__value'}

        try:

            self._admin_mode = memorized_attr_dict['adminMode']

            if self._admin_mode not in [AdminMode.ONLINE, AdminMode.MAINTENANCE]:

                self._health_state = HealthState.UNKNOWN

                self.set_state(tango.DevState.DISABLE)

        except KeyError as key_err:

            self.logger.info("Key {} not found".format(key_err))