Unverified Commit c9656f6f authored by acpaquette's avatar acpaquette Committed by GitHub
Browse files

Hayabusa amica Ephemeris Fix (#592) 

* Fixed hayabusa ephemeris times

* Updated function doc string

* Added test for new property

* added changelog entry
parent 1d786e1d

CHANGELOG.md

+1 −0
Original line number Diff line number Diff line
@@ -40,6 +40,7 @@ release. 
### Fixed



- Fixed landed sensors to correctly project locally [#590](https://github.com/DOI-USGS/ale/pull/590)

- Fixed Hayabusa amica center time computation to match ISIS [#592](https://github.com/DOI-USGS/ale/pull/592)



## [0.10.0] - 2024-01-08

ale/drivers/hayabusa_drivers.py

+12 −0
Original line number Diff line number Diff line
@@ -20,6 +20,18 @@ class HayabusaAmicaIsisLabelNaifSpiceDriver(Framer, IsisLabel, NaifSpice, Radial 
        lookup_table = {'AMICA': 'HAYABUSA_AMICA'}

        return lookup_table[super().instrument_id]

    

    @property

    def center_ephemeris_time(self):

        """

        Returns the start ephemeris time plus half the exposure duration.



        Returns

        -------

        : double

          Center ephemeris time for an image

        """

        return self.ephemeris_start_time + self.exposure_duration / 2



    @property

    def sensor_model_version(self):

        """

tests/pytests/test_hayabusa_drivers.py

+5 −0
Original line number Diff line number Diff line
@@ -38,6 +38,11 @@ class test_amica_isis_naif(unittest.TestCase): 
    def test_instrument_id(self):

        assert self.driver.instrument_id == "HAYABUSA_AMICA"



    def test_center_ephemeris_time(self):

        with patch('ale.drivers.hayabusa_drivers.spice.scs2e', return_value=12345) as scs2e:

            assert self.driver.center_ephemeris_time == 12345 + 0.0109

            scs2e.assert_called_with(-130, '2457499394')

    

    def test_sensor_model_version(self):

        assert self.driver.sensor_model_version == 1