Moved detector start pixel into base and defaulted to 0 (#218) (8f37849d) · Commits · aflab / astrogeology / Ale

ale/base/base.py

+6 −6

Original line number	Diff line number	Diff line
		@@ -53,25 +53,25 @@ class Driver(ABC):
		"""
		pass

		@abc.abstractproperty
		@property
		def detector_start_line(self):
		"""
		Returns
		-------
		: int
		Detector line corresponding to the first image line
		Zero based Detector line corresponding to the first image line
		"""
		pass
		return 0

		@abc.abstractproperty
		@property
		def detector_start_sample(self):
		"""
		Returns
		-------
		: int
		Detector sample corresponding to the first image sample
		Zero based Detector sample corresponding to the first image sample
		"""
		pass
		return 0

		@abc.abstractproperty
		def sample_summing(self):

+0 −20

Original line number	Diff line number	Diff line
		@@ -175,23 +175,3 @@ class CassiniIssPds3LabelNaifSpiceDriver(Pds3Label, NaifSpice, Framer, RadialDis
		ISIS sensor model version
		"""
		return 1

		@property
		def detector_start_sample(self):
		"""
		Returns
		-------
		: int
		Detector sample corresponding to the first image sample
		"""
		return 1

		@property
		def detector_start_line(self):
		"""
		Returns
		-------
		: int
		Detector line corresponding to the first image line
		"""
		return 1

+0 −20

Original line number	Diff line number	Diff line
		@@ -198,26 +198,6 @@ class DawnFcPds3NaifSpiceDriver(Pds3Label, NaifSpice, Framer, Driver):
		pixel_size = spice.gdpool('INS{}_PIXEL_SIZE'.format(self.ikid), 0, 1)[0] * 0.001
		return [0.0, 0.0, 1/pixel_size]

		@property
		def detector_start_line(self):
		"""
		Returns
		-------
		: int
		Detector line corresponding to the first image line
		"""
		return 1

		@property
		def detector_start_sample(self):
		"""
		Returns
		-------
		: int
		Detector sample corresponding to the first image sample
		"""
		return 1

		@property
		def sensor_model_version(self):
		"""

+2 −12

Original line number	Diff line number	Diff line
		@@ -481,16 +481,6 @@ class KaguyaTcPds3NaifSpiceDriver(Pds3Label,NaifSpice, LineScanner, Driver):
		"""
		return self.label["FIRST_PIXEL_NUMBER"]

		@property
		def detector_start_line(self):
		"""
		Returns
		-------
		: int
		Detector line corresponding to the first image sample
		"""
		return 1


		@property
		def sensor_model_version(self):

+0 −24

Original line number	Diff line number	Diff line
		@@ -90,30 +90,6 @@ class LroLrocPds3LabelNaifSpiceDriver(NaifSpice, Pds3Label, LineScanner, Driver)
		"""
		return 2

		@property
		def detector_start_sample(self):
		"""
		Returns the starting sample contained in the image

		Returns
		-------
		: int
		Returns the starting sample
		"""
		return 1

		@property
		def detector_start_line(self):
		"""
		Returns the starting line contained in the image

		Returns
		-------
		: int
		Returns the starting line
		"""
		return 1

		@property
		def usgscsm_distortion_model(self):
		"""