Unverified Commit f57caf15 authored by Kelvin Rodriguez's avatar Kelvin Rodriguez Committed by GitHub
Browse files

logs now report as pvgroups are added to pvl logs (fixes #4914) (#4990) 

* updated how pvl logs work in order to report as groups are added to a pvl log

* removed non-exitant header

* constness is dumb

* applog case sensativity

* missed a spot

* ugh

* removed forward declare

* added changelog line
parent 87915a8c

CHANGELOG.md

+2 −0
Original line number Diff line number Diff line
@@ -40,6 +40,8 @@ release. 
- Added changes to lronaccal to use time-dependent dark files for dark correction and use of specific dark files for images with exp code of zero. Also added GTests for lronaccal and refactored code to make callable. Added 3 truth cubes to testing directory.  PR[#4520](https://github.com/USGS-Astrogeology/ISIS3/pull/4520)

### Changed

- Updated the LRO calibration application Lrowaccal to add a units label to the RadiometricType keyword of the Radiometry group in the output cube label if the RadiometricType parameter is Radiance. No functionality is changed if the RadiometricType parameter is IOF. Lrowaccal has also been refactored to be callable for testing purposes. Issue: [#4939](https://github.com/USGS-Astrogeology/ISIS3/issues/4939), PR: [#4940](https://github.com/USGS-Astrogeology/ISIS3/pull/4940)

- Changed how logs are reported so they no longer only printing at the end of the applications execution. [#4914](https://github.com/USGS-Astrogeology/ISIS3/issues/4914)





### Added

- Improved functionality of msi2isis and MsiCamera model to support new Eros dataset, including support for Gaskell's SUMSPICE files that adjust timing, pointing and spacecraft position ephemeris. [#4886](https://github.com/USGS-Astrogeology/ISIS3/issues/4886)

isis/src/base/apps/automos/automos.cpp

+2 −2
Original line number Diff line number Diff line
@@ -78,7 +78,7 @@ namespace Isis { 
        PvlGroup outsiders("Outside");

        outsiders += PvlKeyword("File", list[i].toString());

        if (log) {

          log->addGroup(outsiders);

          log->addLogGroup(outsiders);

        }

      }

      else {
@@ -95,7 +95,7 @@ namespace Isis { 
    // Logs the input file location in the mosaic

    for (int i = 0; i < m.imagePositions().groups(); i++) {

      if (log) {

        log->addGroup(m.imagePositions().group(i));

        log->addLogGroup(m.imagePositions().group(i));

      }

    }

isis/src/base/apps/automos/main.cpp

+1 −13
Original line number Diff line number Diff line
@@ -25,20 +25,8 @@ map <QString, void *> GuiHelpers() { 
void IsisMain() {

  UserInterface &ui = Application::GetUserInterface();

  Pvl appLog;

  try {

  automos(ui, &appLog);

}

  catch (...) {

    for (auto grpIt = appLog.beginGroup(); grpIt!= appLog.endGroup(); grpIt++) {

      Application::Log(*grpIt);

    }

    throw;

  }



  for (auto grpIt = appLog.beginGroup(); grpIt!= appLog.endGroup(); grpIt++) {

    Application::Log(*grpIt);

  }

}



// Function to calculate the ground range from multiple inputs (list of images)

void calcRange(double &minLat, double &maxLat, double &minLon, double &maxLon) {

isis/src/base/apps/cam2map/cam2map.cpp

+1 −1
Original line number Diff line number Diff line
@@ -433,7 +433,7 @@ namespace Isis { 


    // add mapping to print.prt

    if(log) {

      log->addGroup(cleanMapping);

      log->addLogGroup(cleanMapping);

    }



    // Cleanup

isis/src/base/apps/cam2map/main.cpp

+1 −13
Original line number Diff line number Diff line
@@ -35,20 +35,8 @@ map <QString, void *> GuiHelpers() { 
void IsisMain() {

  UserInterface &ui = Application::GetUserInterface();

  Pvl appLog;

  try {

  cam2map(ui, &appLog);

}

  catch (...) {

    for (auto grpIt = appLog.beginGroup(); grpIt!= appLog.endGroup(); grpIt++) {

      Application::Log(*grpIt);

    }

    throw;

  }



  for (auto grpIt = appLog.beginGroup(); grpIt!= appLog.endGroup(); grpIt++) {

    Application::Log(*grpIt);

  }

}



// Helper function to print out mapfile to session log

void printMap() {