Unverified Commit f32dcfb9 authored by Makayla Shepherd's avatar Makayla Shepherd Committed by GitHub
Browse files

Merge pull request #146 from chrisryancombs/m05360 

Fixed issue with apps core dumping when ISISROOT not set. Fixes #5360.
parents 9efec548 e09fda57

isis/src/base/objs/Application/Application.cpp

+0 −8
Original line number Diff line number Diff line
@@ -102,14 +102,6 @@ namespace Isis { 
    strncpy(env, "LANG=en_US", 1023);

    putenv(env);



    // Verify ISISROOT was set

    if (getenv("ISISROOT") == NULL || QString(getenv("ISISROOT")) == "") {

      QString message = "Please set ISISROOT before running any Isis "

          "applications";

      cerr << message << endl;

      abort();

    }



    // Get the starting cpu time, direct I/Os, page faults, and swaps

    //p_startClock = clock();

    p_startDirectIO = DirectIO();

isis/src/base/objs/Isis/Isis.h

+9 −1
Original line number Diff line number Diff line
@@ -107,6 +107,14 @@ void InterruptSignal(int); 
 * @return int

 */

int main(int argc, char *argv[]) {

  // Verify ISISROOT was set

  // Note: as printing and logging IExceptions requires ISISROOT to be set (for preferences),

  //       The case below cannot be handled with IExceptions

  if (getenv("ISISROOT") == NULL || QString(getenv("ISISROOT")) == "") {

    std::cerr << "Please set ISISROOT before running any Isis applications" << std::endl;

    exit(1);

  }



#ifdef CWDEBUG

  startMonitoringMemory();

  signal(SIGSEGV, SegmentationFault);

isis/src/qisis/apps/cneteditor/main.cpp

+6 −0
Original line number Diff line number Diff line 
#include "IsisDebug.h"



#include <iostream>



#include "CnetEditorWindow.h"

#include "QIsisApplication.h"
@@ -7,6 +9,10 @@ using namespace Isis; 


int main(int argc, char ** argv)

{

  if (getenv("ISISROOT") == NULL || QString(getenv("ISISROOT")) == "") {

    std::cerr << "Please set ISISROOT before running any Isis applications" << std::endl;

    exit(1);

  }

  QIsisApplication app(argc, argv);

  CnetEditorWindow window;

  window.show();

isis/src/qisis/apps/ipce/ipce.cpp

+4 −1
Original line number Diff line number Diff line
@@ -35,7 +35,10 @@ using namespace std; 
using namespace Isis;



int main(int argc, char *argv[]) {



  if (getenv("ISISROOT") == NULL || QString(getenv("ISISROOT")) == "") {

    std::cerr << "Please set ISISROOT before running any Isis applications" << std::endl;

    exit(1);

  }

  Gui::checkX11();



  try {

isis/src/qisis/apps/qmos/qmos.cpp

+4 −0
Original line number Diff line number Diff line
@@ -13,6 +13,10 @@ using namespace std; 
using namespace Isis;



int main(int argc, char *argv[]) {

  if (getenv("ISISROOT") == NULL || QString(getenv("ISISROOT")) == "") {

    std::cerr << "Please set ISISROOT before running any Isis applications" << std::endl;

    exit(1);

  }

  Isis::Gui::checkX11();



  // Add the Qt plugin directory to the library path