Unverified Commit 4e39c980 authored by Kris J. Becker's avatar Kris J. Becker Committed by GitHub
Browse files

isisdataeval - ISISDATA Evaluation and Verification (#5111) 

* isisdataeval validates/verifies ISISDATA (new)

This new application will evaluate all the files in an ISISDATA local installation for a valid kernel configuration and verify content

* Updated change log for isisdataeval

* Fixed typo in the XML doc

* Correct/updated documentation

* isisdataeval corrections/improvements and docs

This commit updates documentation base upon code review.

Some additional modifications were made to code to clean/clarify some processing and ensure special cases are identified.

Added the VERIFY parameter as its not very straight forward if you don’t add the right parameter (need to hash files to find bad filenames). This option will not require any output files to run both validation (always ran) and verification (optional).

* isisdataeval tools and documentation

The isisdata_mockup.py tool is provide to create an ISISDATA mockup to test the application. This submission documents the process to set up testing in the ISIS Google Test environment.

* isisdataeval add tests, data and ISISDATA mockup fixture

* Add all of isisdataeval ISISDATA mockup for tests

This directory contains a minimal configuration to provide testing for isisdataeval. Note that the total size of all these files is about 120K. See the README.md in ISIS3/isis/src/system/apps/isisdataeval/tools for details on how this data is created.

* isisdataeval tests must keep ignored files

There are some cube files and other files that end up being excluded in .gitignore. An entry was added that included all the files in this commit.
parent f13a7923

.gitignore

+3 −0
Original line number Diff line number Diff line
@@ -58,6 +58,9 @@ install/ 
!isis/tests/data/near/msi2isis/*.lbl

!isis/tests/data/near/msicamera/*.cub



# Ensure the contents of ISISDATA mockup tests are preserved

!isis/tests/data/isisdata/mockup/**/*



# Ignore vs code

.vscode

CHANGELOG.md

+2 −1
Original line number Diff line number Diff line
@@ -55,6 +55,7 @@ release. 


### Added

- Added LatLonGrid Tool to Qview to view latitude and longitude lines if camera model information is present.

- Added a new application, _isisdataeval_, that validates/verifies ISISDATA installations and aids in the development and management of this resource. Users can use _isisdataeval_ to help resolve runtime problems related to ISIS kernels and calibration processing. In fact, it is designed to be used on any directory as it will create a detailed install volume inventory with file/volume hashes and is not restricted to ISIS use. [#5110](https://github.com/USGS-Astrogeology/ISIS3/issues/5110) [#5111](https://github.com/USGS-Astrogeology/ISIS3/pull/5111)



### Deprecated

isis/src/system/apps/isisdataeval/IsisDataModel.cpp

0 → 100644
+813 −0

File added.

Preview size limit exceeded, changes collapsed.

isis/src/system/apps/isisdataeval/IsisDataModel.h

0 → 100644
+887 −0

File added.

Preview size limit exceeded, changes collapsed.

isis/src/system/apps/isisdataeval/Makefile

0 → 100644
+7 −0
Original line number Diff line number Diff line 
ifeq ($(ISISROOT), $(BLANK))

.SILENT:

error:

	echo "Please set ISISROOT";

else

	include $(ISISROOT)/make/isismake.apps

endif
 
 No newline at end of file