Unverified Commit 3b879d0d authored by kledmundson's avatar kledmundson Committed by GitHub
Browse files

Bug fix in noproj to remove persistent temporary lbl file (#5578) 

* Added line to close match cube in noproj.cpp. Not closing the cube resulted in a temporary "*.lbl" file that remained after running the noproj application. Addresses #5577.

* CHANGELOG entry for noproj bug fix. Addresses #5577.

* Added history entry in noproj.xml. Addresses #5577.
parent 33ea3f74

CHANGELOG.md

+1 −0
Original line number Diff line number Diff line
@@ -46,6 +46,7 @@ release. 
- Pinned `suitesparse` dependency version to maximum not including 7.7.0 [#5496](https://github.com/DOI-USGS/ISIS3/issues/5496)



### Fixed

- Fixed a bug in noproj.cpp which left a persisent lbl file after running noproj. [#5577] (https://github.com/DOI-USGS/ISIS3/issues/5577)

- Fixed a bug in QVIEW's FindTool in which camera was prioritized over projction [#5508](https://github.com/DOI-USGS/ISIS3/issues/5508)

- Fixed a bug in PolygonTools in which the program exited before attempting to fix an invalid Polygon [#5520](https://github.com/DOI-USGS/ISIS3/issues/5520)

- Fixed a bug in QVIEW's Stretch tool where the default min/max type was not an available option [#5289](https://github.com/DOI-USGS/ISIS3/issues/5289)

isis/src/base/apps/noproj/noproj.cpp

+2 −1
Original line number Diff line number Diff line
@@ -378,6 +378,7 @@ namespace Isis { 
    Cube matchCube;

    matchCube.open(matchCubeFile.expanded(), "rw");

    cam2cam(icube, &matchCube, cam2camUI);

    matchCube.close();

    

    // Cleanup by deleting the match files

    QStringList detfiles = findAllDetachedFiles( label );

isis/src/base/apps/noproj/noproj.xml

+4 −0
Original line number Diff line number Diff line
@@ -84,6 +84,10 @@ 
    <change name="Ken Edmundson" date="2024-01-09">

          Incorporated Kris Becker's 2021-09-22 bug fix above into USGS code base.

    </change>

    <change name="Ken Edmundson" date="2024-08-07">

          Additional bug fix to address persistent temporary lbl file after

          running noproj. Fixes #5577.

    </change>

  </history>



  <category>