Unverified Commit 36051ead authored by kledmundson's avatar kledmundson Committed by GitHub
Browse files

The cnetedit application has been refactored to be callable; Makefile tests... 

The cnetedit application has been refactored to be callable; Makefile tests have been removed and replaced by gtests (#5348)

* The cnetedit application has been refactored to be callable; Makefile tests have been migrated to gtest format. Addresses #5346.

* Removed extraneous variables from FunctionalTestsCnetedit.cpp. Addresses #5346.

* Updated gtests; replace cubes with labels. Addresses #5346.

* Per review cleaned up sloppy spacing; made global variables static in cnetedit.cpp to avoid issues when linking libisis. Addresses #5346.
parent e7abbc51

CHANGELOG.md

+2 −1
Original line number Diff line number Diff line
@@ -36,7 +36,8 @@ release. 
## [Unreleased]



### Changed

- Cnetedit has been refactored to be callable; old Makefile tests have been removed and replaced by gtests. Issue: [#5322](https://github.com/USGS-Astrogeology/ISIS3/issues/5322), 

- Cnetedit has been refactored to be callable; old Makefile tests have been removed and replaced by gtests. Issue: [#5346](https://github.com/USGS-Astrogeology/ISIS3/issues/5346), 

- Cnetdiff has been refactored to be callable; old Makefile tests have been removed and replaced by gtests. Issue: [#5322](https://github.com/USGS-Astrogeology/ISIS3/issues/5322), 

- Removed the `.py` extention from the _isisdataeval_ tool `isisdata_mockup` for consistency and install it in $ISISROOT/bin; added the `--tojson` and `--hasher` option to _isisdata_mockup_ tool improve utility; updated the tool `README.md` documentation to reflect this change, removed help output and trimmed example results;  fixed paths to test data in `make_isisdata_mockup.sh`. [#5163](https://github.com/DOI-USGS/ISIS3/pull/5163)

- Significantly refactored FASTGEOM processing in <i>findfeatures</i> to accommodate stability and functionality. The scope of the algorithm was taken out of the ImageSource class and isolated to support this feature. [#4772](https://github.com/DOI-USGS/ISIS3/issues/4772)

- Report better information regarding the behavior of <i>findfeatures</i>, FASTGEOM algorithms, and creation of the output network. [#4772](https://github.com/DOI-USGS/ISIS3/issues/4772)

isis/src/control/apps/cnetedit/cnetedit.cpp

0 → 100644
+1127 −0

File added.

Preview size limit exceeded, changes collapsed.

isis/src/control/apps/cnetedit/cnetedit.h

0 → 100644
+27 −0
Original line number Diff line number Diff line 
/** This is free and unencumbered software released into the public domain.



The authors of ISIS do not claim copyright on the contents of this file.

For more details about the LICENSE terms and the AUTHORS, you will

find files of those names at the top level of this repository. **/



/* SPDX-License-Identifier: CC0-1.0 */

#ifndef cnetedit_h

#define cnetedit_h



#include "UserInterface.h"



namespace Isis{

  class ControlNet;

  class ControlPointList;

  class SerialNumberList;



  extern Pvl cnetedit(UserInterface &ui);

  extern Pvl cnetedit(ControlNet &cnet, UserInterface &ui,

                       ControlPointList *cpList=nullptr,

                       SerialNumberList *cubeSnl=nullptr,

                       QMap< QString, QSet<QString> * > *editMeasuresList=nullptr,

                       Pvl *defFile=nullptr,

                       SerialNumberList *validationSnl=nullptr);

}



#endif

isis/src/control/apps/cnetedit/main.cpp

+17 −1035

File changed.

Preview size limit exceeded, changes collapsed.

isis/src/control/apps/cnetedit/tsts/Makefile

deleted100644 → 0
+0 −5
Original line number Diff line number Diff line 
BLANKS = "%-6s"    

LENGTH = "%-40s"



include $(ISISROOT)/make/isismake.tststree