Fixed problem with save project button enabled on ipce open without project... (21b1ee9c) · Commits · aflab / astrogeology / ISIS3

isis/src/qisis/apps/ipce/IpceMainWindow.cpp

+75 −43

Original line number	Diff line number	Diff line
		@@ -203,12 +203,10 @@ namespace Isis {
		addDockWidget(area, dock, orientation);
		}

		// Connections for cleanup in both directions to make sure both views and docks are cleaned up
		connect(newWidget, SIGNAL(destroyed(QObject *)), dock, SLOT(deleteLater()));
		// When dock widget is destroyed, make sure the view it holds is also destroyed
		connect(dock, SIGNAL(destroyed(QObject *)), newWidget, SLOT(deleteLater()));
		// The list of dock widgets needs cleanup as each view is destroyed
		connect(dock, SIGNAL(destroyed(QObject *)),
		this, SLOT(cleanupViewDockList(QObject *)));
		connect(dock, SIGNAL(destroyed(QObject )), this, SLOT(cleanupViewDockList(QObject )));

		// Save view docks for cleanup during a project close
		m_viewDocks.append(dock);
		@@ -231,6 +229,7 @@ namespace Isis {
		*/
		void IpceMainWindow::removeView(QWidget *view) {
		view->close();
		qDebug()<<"IpceMainWindow::removeView view = "<<view;
		delete view;
		}

		@@ -259,6 +258,22 @@ namespace Isis {
		}


		/**
		* This is needed so that the project clean flag is not set to false when move and resize events
		* are emitted from ipce.cpp when IpceMainWindow::show() is called.
		* The non-spontaneous or internal QShowEvent is only emitted once from ipce.cpp, so the project
		* clean flag can be reset.
		*
		* @param event QShowEvent*
		*
		*/
		void IpceMainWindow::showEvent(QShowEvent *event) {
		if (!event->spontaneous()) {
		m_directory->project()->setClean(true);
		}
		}


		/**
		* Filters out events from views so they can be handled by the main
		* window. Filters out DragEnter Drop and ContextMenu events from
		@@ -476,50 +491,18 @@ namespace Isis {
		}


		/**
		* Write the window positioning and state information out to a
		* config file. This allows us to restore the settings when we
		* create another main window (the next time this program is run).
		*
		* The state will be saved according to the currently loaded project and its name.
		*
		* When no project is loaded (i.e. the default "Project" is open), the config file used is
		* $HOME/.Isis/$APPNAME/$APPNAME_Project.config.
		* When a project, ProjectName, is loaded, the config file used is
		* $HOME/.Isis/$APPNAME/$APPNAME_ProjectName.config.
		*
		* @param[in] project Pointer to the project that is currently loaded (default is "Project")
		*
		* @internal
		* @history 2016-11-09 Ian Humphrey - Settings are now written according to the loaded project.
		* References #4358.
		* @history 2017-10-17 Tyler Wilson Added a [recent projects] group for the saving and
		* restoring of recently opened projects. References #4492.
		*/
		void IpceMainWindow::writeSettings(Project *project) {
		void IpceMainWindow::writeGlobalSettings(Project *project) {

		// Ensure that we are not using a NULL pointer
		if (!project) {
		QString msg = "Cannot write settings with a NULL Project pointer.";
		throw IException(IException::Programmer, msg, _FILEINFO_);
		}
		QString appName = QApplication::applicationName();
		QSettings projectSettings(
		FileName("$HOME/.Isis/" + appName + "/" + appName + "_" + project->name() + ".config")
		.expanded(),
		QSettings::NativeFormat);

		QSettings globalSettings(
		FileName("$HOME/.Isis/" + appName + "/" + appName + "_" + "Project.config")
		.expanded(),
		QSettings::NativeFormat);

		projectSettings.setValue("geometry", QVariant(geometry()));
		projectSettings.setValue("windowState", saveState());
		// projectSettings.setValue("size", size());
		// projectSettings.setValue("pos", pos());

		projectSettings.setValue("maxThreadCount", m_maxThreadCount);
		// If temporary project open same geometry of mainwindow
		if (project->projectRoot().contains("tmpProject")) {
		globalSettings.setValue("geometry", QVariant(geometry()));
		}

		globalSettings.setValue("maxThreadCount", m_maxThreadCount);
		globalSettings.setValue("maxRecentProjects",m_maxRecentProjects);
		@@ -590,6 +573,48 @@ namespace Isis {
		}


		/**
		* Write the window positioning and state information out to a
		* config file. This allows us to restore the settings when we
		* create another main window (the next time this program is run).
		*
		* The state will be saved according to the currently loaded project and its name.
		*
		* When no project is loaded (i.e. the default "Project" is open), the config file used is
		* $HOME/.Isis/$APPNAME/$APPNAME_Project.config.
		* When a project, ProjectName, is loaded, the config file used is
		* $HOME/.Isis/$APPNAME/$APPNAME_ProjectName.config.
		*
		* @param[in] project Pointer to the project that is currently loaded (default is "Project")
		*
		* @internal
		* @history 2016-11-09 Ian Humphrey - Settings are now written according to the loaded project.
		* References #4358.
		* @history 2017-10-17 Tyler Wilson Added a [recent projects] group for the saving and
		* restoring of recently opened projects. References #4492.
		*/
		void IpceMainWindow::writeSettings(Project *project) {

		// Ensure that we are not using a NULL pointer
		if (!project) {
		QString msg = "Cannot write settings with a NULL Project pointer.";
		throw IException(IException::Programmer, msg, _FILEINFO_);
		}
		QString appName = QApplication::applicationName();
		QSettings projectSettings(
		FileName("$HOME/.Isis/" + appName + "/" + appName + "_" + project->name() + ".config")
		.expanded(),
		QSettings::NativeFormat);

		projectSettings.setValue("geometry", QVariant(geometry()));
		projectSettings.setValue("windowState", saveState());
		// projectSettings.setValue("size", size());
		// projectSettings.setValue("pos", pos());

		projectSettings.setValue("maxThreadCount", m_maxThreadCount);
		}


		/**
		* Read the window positioning and state information from the config file.
		*
		@@ -624,6 +649,11 @@ namespace Isis {
		if (project->name() == "Project") {
		setWindowTitle("ipce");

		// Read generic geometry
		if (settings.contains("geometry")) {
		setGeometry(settings.value("geometry").value<QRect>());
		}

		QStringList projectNameList;
		QStringList projectPathList;
		settings.beginGroup("recent_projects");
		@@ -680,6 +710,7 @@ namespace Isis {
		move(settings.value("pos").toPoint());
		}
		}
		// m_directory->project()->setClean(true);
		}


		@@ -709,7 +740,8 @@ namespace Isis {
		m_directory->project()->save();
		}
		}
		writeSettings(m_directory->project());
		// Write global settings, for now this is for the project "Project"
		writeGlobalSettings(m_directory->project());
		m_directory->project()->clear();

		QMainWindow::closeEvent(event);

isis/src/qisis/apps/ipce/IpceMainWindow.h

+9 −0

Original line number	Diff line number	Diff line
		@@ -24,6 +24,7 @@
		*/

		#include "ViewSubWindow.h"
		#include <QEvent>
		#include <QMainWindow>
		#include <QPointer>
		#include <QProgressBar>
		@@ -145,6 +146,12 @@ namespace Isis {
		* @history 2018-06-15 Tracie Sucharski - Fixed break to recent projects. The readSettings
		* must be called before initializeActions to get the recent projects
		* from the config file.
		* @history 2018-06-22 Tracie Sucharski - Cleanup destruction of dock widgets and the views they
		* hold. Extra destroy slots were causing double deletion of memory.
		* @history 2018-06-22 Tracie Sucharski - Added a showEvent handler so that the project clean
		* state can be reset after the IpceMainWindow::show() causes resize and
		* move events which in turn cause the project clean flag to be false
		* even though the project has just opened.
		*
		*/
		class IpceMainWindow : public QMainWindow {
		@@ -161,8 +168,10 @@ namespace Isis {

		void readSettings(Project *);
		void writeSettings(Project *project);
		void writeGlobalSettings(Project *project);

		protected:
		void showEvent(QShowEvent *event);
		void closeEvent(QCloseEvent *event);
		bool eventFilter(QObject watched, QEvent event);