Unverified Commit 1facdb76 authored by Cordell Michaud's avatar Cordell Michaud Committed by GitHub
Browse files

Refactor lrowaccal for testability and add a radiance units label to the output cube (#4940) 



* Add radiance units label in lrowaccal output cube

* Refactor lrowaccal app to be callable for testing and add radiance units to output PVL

* Update formatting and NULL initialization

* Add NULL assignments after deletions

* Add CubeAttributeOutput to output cube initialization

* Add functional test for lrowaccal units label addition and accompanying test cube

* Refactor lrowaccal to remove global variables and convert helper functions to lambdas with captures

* Update history section of lrowaccal XML file with refactoring and output cube units label changes

* Remove old lrowaccal Makefile tests

* Add lrowaccal functional test to ensure that the radiance units label is not inserted for RadiometricType IOF

* Add Cordell Michaud to the .zenodo.json document

* Add lrowaccal changes to CHANGELOG.md

* Clean up lrowaccal includes and leftover comment

* Re-add lrowaccal Makefile tests

* Re-add disclaimer to top of lrowaccal's main.cpp file

* Add input attributes retrieval to lrowaccal.cpp

* Fix lrowaccal functional test error messages and add PVl group and existence checks

* Move lrowaccal units change message to Changed sub-header in CHANGELOG.md

* Simplify lrowaccal functional test assertions

Co-authored-by: default avatarVictor Silva <victor.silva@asu.edu>
parent aab45637

.zenodo.json

+4 −0
Original line number Diff line number Diff line
@@ -304,6 +304,10 @@ 
      "affiliation": "University of California, Los Angeles",

      "name": "Mehlman, Bob"

    },

    {

      "affiliation": "Arizona State University",

      "name": "Michaud, Cordell"

    },

    {

      "name": "Milazzo, Moses"

    },

CHANGELOG.md

+1 −0
Original line number Diff line number Diff line
@@ -38,6 +38,7 @@ release. 
- Added a new application, framestitch, for stitching even and odd push frame images back together prior to processing in other applications. [4924](https://github.com/USGS-Astrogeology/ISIS3/issues/4924)



### Changed

- Updated the LRO calibration application Lrowaccal to add a units label to the RadiometricType keyword of the Radiometry group in the output cube label if the RadiometricType parameter is Radiance. No functionality is changed if the RadiometricType parameter is IOF. Lrowaccal has also been refactored to be callable for testing purposes. Issue: [#4939](https://github.com/USGS-Astrogeology/ISIS3/issues/4939), PR: [#4940](https://github.com/USGS-Astrogeology/ISIS3/pull/4940)



### Added

- Improved functionality of msi2isis and MsiCamera model to support new Eros dataset, including support for Gaskell's SUMSPICE files that adjust timing, pointing and spacecraft position ephemeris. [#4886](https://github.com/USGS-Astrogeology/ISIS3/issues/4886)

isis/src/lro/apps/lrowaccal/lrowaccal.cpp

0 → 100644
+809 −0

File added.

Preview size limit exceeded, changes collapsed.

isis/src/lro/apps/lrowaccal/lrowaccal.h

0 → 100644
+13 −0
Original line number Diff line number Diff line 
#ifndef lrowaccal_h

#define lrowaccal_h



#include "Cube.h"

#include "UserInterface.h"





namespace Isis {

  extern void lrowaccal(UserInterface &ui);

  extern void lrowaccal(Cube *icube, UserInterface &ui);

}



#endif
 
 No newline at end of file

isis/src/lro/apps/lrowaccal/lrowaccal.xml

+6 −0
Original line number Diff line number Diff line
@@ -240,6 +240,12 @@ 
    <change name="Stuart Sides" date="2021-02-22">

      Added ability to get the sun distance from the camera.

    </change>

    <change name="Cordell Michaud" date="2022-05-03">

      Refactored lrowaccal to be callable for testing and to remove global 

      variables and helper functions. Added units label "W/m2/sr/um" to 

      RadiometricType keyword in output cube label when RadiometricType is 

      AbsoluteRadiance.

    </change>

  </history>



  <groups>