Unverified Commit 1ba60d68 authored by acpaquette's avatar acpaquette Committed by GitHub
Browse files

Campt attribute fix (#5269) 

* Prevent cube manager from setting the virtual band

* Pass potential cube attributes through to the cube manager in campt

* Added changelog entry

* Fixed change log entry
parent 53e3bc01

CHANGELOG.md

+1 −0
Original line number Diff line number Diff line
@@ -65,6 +65,7 @@ release. 
- Fixed a bug in the <i>cnetwinnow</i> test that did not clean/remove it during test runs.

- Fixed <i>findfeatures</i> instantiation and use of projection classes to correctly return geometry data from projected images and mosaics. [#4772](https://github.com/DOI-USGS/ISIS3/issues/4772)

- Fixed `cubeit` attribute error to allow attribute specification on the output cube filename [#5234](https://github.com/DOI-USGS/ISIS3/issues/5234)

- Fixed `campt` to handle input band selection attribute correctly [#5234](https://github.com/DOI-USGS/ISIS3/issues/5235)



## [8.0.0] - 2023-04-19

isis/src/base/apps/campt/campt.cpp

+8 −1
Original line number Diff line number Diff line
@@ -42,7 +42,14 @@ namespace Isis{ 
    else

        campt.SetCSVOutput(true);



    campt.SetCube(cube->fileName());

    QString inputCubePath = "";

    try {

      inputCubePath = ui.GetCubeName("FROM");

    }

    catch (IException &e) {

      inputCubePath = cube->fileName();

    }

    campt.SetCube(inputCubePath);



    // Grab the provided points (coordinates)

    QList< QPair<double, double> > points = getPoints(ui, ui.WasEntered("COORDLIST"));

isis/src/base/objs/CubeManager/CubeManager.cpp

+0 −2
Original line number Diff line number Diff line
@@ -109,8 +109,6 @@ namespace Isis { 
    if (searchResult == p_cubes.end()) {

      p_cubes.insert(fileName, new Cube());

      searchResult = p_cubes.find(fileName);

      // Bands are the only thing input attributes can affect

      (*searchResult)->setVirtualBands(attIn.bands());



      // Need to clean up memory if there is a problem opening a cube

      // This allows the CubeManager class to clean up the dynamically alloc'd